Hi
Am 01.10.26 um 00:22 schrieb Matheus Alves de Almeida:
The qxl driver currently returns -EINVAL when the emulated qxl revision
is too old. This is not a driver initialization failure but rather a
match rejection, which should return -ENODEV.
Change the value returned when the qxl revision is below 4 to -ENODEV.
Switch the xf86-video-qxl suggestion log to be info level, as this is
not an error.
Fixes: f64122c1f6ad ("drm: add new QXL driver. (v1.4)")
Signed-off-by: Matheus Alves de Almeida <[email protected]>
---
drivers/gpu/drm/qxl/qxl_drv.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/qxl/qxl_drv.c b/drivers/gpu/drm/qxl/qxl_drv.c
index 97df9d3d6..35b83b1bb 100644
--- a/drivers/gpu/drm/qxl/qxl_drv.c
+++ b/drivers/gpu/drm/qxl/qxl_drv.c
@@ -82,9 +82,9 @@ qxl_pci_probe(struct pci_dev *pdev, const struct
pci_device_id *ent)
int ret;
if (pdev->revision < 4) {
- DRM_ERROR("qxl too old, doesn't support client_monitors_config,"
- " use xf86-video-qxl in user mode");
- return -EINVAL; /* TODO: ENODEV ? */
+ dev_info(&pdev->dev,
+ "qxl too old, doesn't support client_monitors_config, use
xf86-video-qxl in user mode\n");
This call should become dev_err() instead.
Best regards
Thomas
+ return -ENODEV;
}
qdev = devm_drm_dev_alloc(&pdev->dev, &qxl_driver,
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Stefan Gaiser, Jochen Jaser, Abhinav Puri, (HRB 36809, AG Nürnberg)
