Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] build: imx-lcdc broken due to removed drm_simple_display_pipe --
commit 34fb6e586b77e29b94177632c0a641cf060ef4ce Author: Thomas Zimmermann <[email protected]> drm/kms-helper: Remove struct drm_simple_display_pipe and helpers This commit removes struct drm_simple_display_pipe and its related helpers, stating that they are no longer used by any drivers. It also updates the TODO list to reflect this cleanup. > There are no drivers using struct drm_simple_display_pipe. Remove > the data type and all related helpers. [Severity: Low] Is this statement fully accurate? It appears the imx-lcdc driver still relies on these structs and functions. Building with CONFIG_DRM_IMX_LCDC=y currently fails due to incomplete types and implicit function declarations caused by this removal. For example, in drivers/gpu/drm/imx/lcdc/imx-lcdc.c, the struct is still embedded: struct imx_lcdc { ... struct drm_device *drm; struct drm_simple_display_pipe pipe; ... And initialized in imx_lcdc_probe(): ret = drm_simple_display_pipe_init(drm, &lcdc->pipe, &imx_lcdc_pipe_funcs, imx_lcdc_formats, ARRAY_SIZE(imx_lcdc_formats), NULL, NULL); Does this driver need to be converted to regular atomic helpers before removing the simple-pipe infrastructure? -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=2
