Hi Rob, On Fri Sep 18, 2026 at 11:35 PM CEST, Rob Herring wrote: > On Fri, Sep 18, 2026 at 04:40:04PM +0200, Luca Weiss wrote: >> Novatek NT37705 is a display driver IC used to drive AMOLED DSI panels. >> >> Describe it and the panel in the Fairphone (Gen. 6) (BJ631JHM-T71-D900 >> from BOE) using it. >> >> Reviewed-by: Krzysztof Kozlowski <[email protected]> >> Link: >> https://lore.kernel.org/r/[email protected]/ >> Signed-off-by: Luca Weiss <[email protected]> >> --- >> .../bindings/display/panel/novatek,nt37705.yaml | 72 >> ++++++++++++++++++++++ >> 1 file changed, 72 insertions(+) >> >> diff --git >> a/Documentation/devicetree/bindings/display/panel/novatek,nt37705.yaml >> b/Documentation/devicetree/bindings/display/panel/novatek,nt37705.yaml >> new file mode 100644 >> index 000000000000..1c796599f6fc >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt37705.yaml > > Did novatek,nt37705 get dropped as a compatible, but the filename > remains?
That's how himax,hx83112a.yaml and himax,hx83112b.yaml are as well, which I have upstreamed before. I *really* don't have strong opinions either way, but as in the email referred to in "Link:" the versions I have upstreamed before have been accepted without issue, and even discussion pointing in the way I have done things here. > >> @@ -0,0 +1,72 @@ >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/display/panel/novatek,nt37705.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Novatek NT37705-based DSI display panels >> + >> +maintainers: >> + - Luca Weiss <[email protected]> >> + >> +description: >> + The Novatek NT37705 is a generic DSI Panel IC used to control AMOLED >> panels. >> + >> +allOf: >> + - $ref: panel-common.yaml# >> + >> +properties: >> + compatible: >> + contains: > > As sashiko reports, "contains" is too loose. Will fix, seems to also be an issue in the hx83112a/b yamls. > >> + const: boe,bj631jhm-t71-d900 >> + >> + reg: >> + maxItems: 1 >> + >> + vddio-supply: >> + description: I/O voltage rail >> + >> + dvdd-supply: >> + description: Digital voltage rail >> + >> + vci-supply: >> + description: Analog voltage rail >> + >> +required: >> + - compatible >> + - reg >> + - reset-gpios >> + - vddio-supply >> + - dvdd-supply >> + - vci-supply >> + - port >> + >> +unevaluatedProperties: false >> + >> +examples: >> + - | >> + #include <dt-bindings/gpio/gpio.h> >> + >> + dsi { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + panel@0 { >> + compatible = "boe,bj631jhm-t71-d900"; >> + reg = <0>; >> + >> + reset-gpios = <&tlmm 12 GPIO_ACTIVE_LOW>; >> + >> + vci-supply = <&vreg_l19b>; >> + vddio-supply = <&vreg_l9b>; >> + dvdd-supply = <&vreg_oled_dvdd_1p2>; >> + >> + port { >> + panel_in_0: endpoint { >> + remote-endpoint = <&dsi0_out>; >> + }; >> + }; >> + }; >> + }; >> + >> +... >> >> -- >> 2.55.0 >>
