Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] dt-bindings: display/msm: dp-controller: missing conditional constraints for Kaanapali --
commit 120c2a5db230d526e6a48bd35eae767dbf9663c7 Author: Balaji Kalkonda <[email protected]> dt-bindings: display/msm: dp-controller: Add Kaanapali Add DisplayPort controller for Qualcomm Kaanapali SoC which so far looks fully compatible with earlier SM8650 variant. > diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > index 094a6383bb779..8bb0f6e15942f 100644 > --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > @@ -19,6 +19,7 @@ properties: > oneOf: > - enum: > - qcom,glymur-dp > + - qcom,kaanapali-dp > - qcom,sa8775p-dp > - qcom,sc7180-dp > - qcom,sc7280-dp [Severity: Low] Does this new compatible string cause a regression by bypassing the stricter hardware constraints defined for the SM8650 variant? The commit message states the Kaanapali SoC looks fully compatible with the earlier SM8650 variant. However, qcom,kaanapali-dp is added as a standalone enum item without being added to the existing conditional constraints. Should qcom,kaanapali-dp also be included in the allOf conditional block for qcom,sm8650-dp to enforce the reg property constraints: - if: properties: compatible: contains: enum: - qcom,sm8650-dp then: properties: reg: minItems: 5 Without being added to this enum array, running make dt_binding_check on a device tree containing qcom,kaanapali-dp with fewer than the required 5 reg items or 6 clocks could silently pass schema validation. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
