Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] video/hdmi: missing hdmi_eotf_get_name() usage in hdmi_drm_infoframe_log() --
commit b4b5c92367345e70aebcf91cfdea62895c2744ff Author: Pranay Samala <[email protected]> video/hdmi: Add hdmi_eotf_get_name() This patch introduces hdmi_eotf_get_name() to provide human-readable strings for electro-optical transfer functions. The helper is placed next to other similar hdmi string helpers. > diff --git a/drivers/video/hdmi.c b/drivers/video/hdmi.c > index 45b42f14a7503..cd62afcd38d7d 100644 > --- a/drivers/video/hdmi.c > +++ b/drivers/video/hdmi.c [ ... ] > +const char *hdmi_eotf_get_name(enum hdmi_eotf eotf) > +{ > + switch (eotf) { > + case HDMI_EOTF_TRADITIONAL_GAMMA_SDR: > + return "Traditional gamma SDR"; > + case HDMI_EOTF_TRADITIONAL_GAMMA_HDR: > + return "Traditional gamma HDR"; > + case HDMI_EOTF_SMPTE_ST2084: > + return "SMPTE ST2084"; > + case HDMI_EOTF_BT_2100_HLG: > + return "BT.2100 HLG"; > + } > + return "Invalid"; > +} > +EXPORT_SYMBOL(hdmi_eotf_get_name); > + > static void hdmi_drm_infoframe_log(const char *level, > struct device *dev, > const struct hdmi_drm_infoframe *frame) [Severity: Low] This isn't a bug, but could hdmi_drm_infoframe_log() be updated to use this new helper? Currently, the function logs the eotf field as a raw integer: drivers/video/hdmi.c:hdmi_drm_infoframe_log() { ... hdmi_log("eotf: %d\n", frame->eotf); ... } Updating this to use hdmi_eotf_get_name() would match the surrounding log format conventions. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
