Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] refactor: duplicate intel_joiner_valid_primary_pipe_mask() declaration --
commit 8219a04938cb40be1f657190cac49de622685e24 Author: Ankit Nautiyal <[email protected]> drm/i915/joiner: Move joiner pipe mask helper to intel_joiner.c This commit moves the intel_joiner_valid_primary_pipe_mask() helper and its dependencies from intel_display.c to intel_joiner.c to group joiner functionality together. It also adds the function declaration to intel_joiner.h. > diff --git a/drivers/gpu/drm/i915/display/intel_joiner.h > b/drivers/gpu/drm/i915/display/intel_joiner.h > index 85e19ed1527f5..962b9724c1126 100644 > --- a/drivers/gpu/drm/i915/display/intel_joiner.h > +++ b/drivers/gpu/drm/i915/display/intel_joiner.h > @@ -22,4 +22,6 @@ bool intel_joiner_candidate_valid(struct intel_connector > *connector, > for ((__num_joined_pipes) = 1; (__num_joined_pipes) <= > (I915_MAX_PIPES); (__num_joined_pipes)++) \ > for_each_if(intel_joiner_candidate_valid(__connector, > (__mode)->hdisplay, __num_joined_pipes)) > > +u8 intel_joiner_valid_primary_pipe_mask(struct intel_display *display, int > num_joined_pipes); > + [Severity: Low] This isn't a bug, but should the existing declaration of intel_joiner_valid_primary_pipe_mask() in intel_display.h also be removed? When this function was moved to intel_joiner.c, a new declaration was added here, but the original prototype was left behind in intel_display.h. This creates a duplicate function prototype. Callers in intel_display.c might continue to compile by implicitly relying on the stale declaration instead of properly including intel_joiner.h. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=53
