On Tue, Oct 06, 2026 at 12:22:00PM +0000, Laurentiu Palcu wrote: > +#include <linux/mod_devicetable.h> > +#include <linux/platform_device.h>
Please rely on linux/platform_device.h to provide of_device_id and drop
linux/mod_devicetable.h.
> +static const struct of_device_id dcif_dt_ids[] = {
> + { .compatible = "nxp,imx94-dcif", },
No , before } please.
> + { /* sentinel */ }
> +};
> +MODULE_DEVICE_TABLE(of, dcif_dt_ids);
> +
> +static struct platform_driver dcif_platform_driver = {
> + .probe = dcif_probe,
> + .remove = dcif_remove,
> + .shutdown = dcif_shutdown,
> + .driver = {
> + .name = "imx-dcif-drm",
> + .of_match_table = dcif_dt_ids,
> + .pm = pm_ptr(&dcif_pm_ops),
> + },
I generally don't like the effort to keep the = aligned in such
structures and don't recommend to even try it. Still more if it's
inconsitent from the start. Just use a single space before the =.
Best regards
Uwe
signature.asc
Description: PGP signature
