On Fri, Sep 11, 2026 at 09:06:40PM +0530, Nabige Aala wrote: > From: Ritesh Kumar <[email protected]> > > Nord requires different AUX channel and VCO divider settings compared > to existing SoCs. Add edp_phy_aux_cfg_nord and edp_phy_vco_div_cfg_nord > with values sourced from HPG Tables 2-1-a and 2-1-b respectively. > > Signed-off-by: Ritesh Kumar <[email protected]> > Signed-off-by: Nabige Aala <[email protected]> > --- > drivers/phy/qualcomm/phy-qcom-edp.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c > b/drivers/phy/qualcomm/phy-qcom-edp.c > index 373f13b3d6d5..ee0d7f1a90fe 100644 > --- a/drivers/phy/qualcomm/phy-qcom-edp.c > +++ b/drivers/phy/qualcomm/phy-qcom-edp.c > @@ -1508,6 +1508,25 @@ static int qcom_edp_phy_probe(struct platform_device > *pdev) > return PTR_ERR_OR_ZERO(phy_provider); > } > > +/* > + * nord AUX config (eDP mode). > + * From HPG Table 2-1-a: edp_phy_aux_bist.csv > + * Index: 0 1 2 3 4 5 6 7 8 9 10 > 11 12 > + */ > +static const u8 edp_phy_aux_cfg_nord[DP_AUX_CFG_SIZE] = { > + 0x00, 0x13, 0xa4, 0x00, 0x0a, 0x26, 0x0a, 0x03, 0x37, 0x03, 0x02, 0x02, > 0x04, > +}; > + > +/* > + * nord VCO_DIV config for eDP mode. > + * From HPG Table 2-1-b AUX Clock Settings (eDP mode) - Nominal/Turbo column. > + * Indices: [0]=1620, [1]=2700, [2]=5400, [3]=8100 > + */ > +static const u8 edp_phy_vco_div_cfg_nord[4] = { > + 0x00, 0x00, 0x02, 0x01, > +}; > +
>From this patch onwards you are introducing -Wunused* warnings for each patch. You *must not* do that. If logical split is what you are aiming here, I can say that it isn't what you are doing here. Please group Nord SoC support in one patch and keep the preparatory patches separate. - Mani -- மணிவண்ணன் சதாசிவம்
