On Tue Oct 13, 2026 at 12:10 PM CEST, Konrad Dybcio wrote:
> On 10/12/26 8:11 PM, Luca Weiss wrote:
>> From: Jasper Korten <[email protected]>
>
> [...]
>
>> Signed-off-by: Jasper Korten <[email protected]>
>> Co-developed-by: Federico Amedeo Izzo <[email protected]>
>> Signed-off-by: Federico Amedeo Izzo <[email protected]>
>> Co-developed-by: Luca Weiss <[email protected]>
>> Signed-off-by: Luca Weiss <[email protected]>
>> Signed-off-by: Luca Weiss <[email protected]>
>
> Good to see the Lucas are in agreement ;)
:)
>
> [...]
>
>> +&pm8350c_gpios {
>> + pmic_lcd_bl_en: pmic-lcd-bl-en-state {
>> + pins = "gpio7";
>> + function = "normal";
>> + bias-disable;
>> + qcom,drive-strength = <PMIC_GPIO_STRENGTH_LOW>;
>> + output-low;
>> + power-source = <0>;
>> + };
>> +
>> + pmic_lcd_bl_pwm: pmic-lcd-bl-pwm-state {
>> + pins = "gpio8";
>> + function = "func1";
>> + bias-disable;
>> + qcom,drive-strength = <PMIC_GPIO_STRENGTH_LOW>;
>> + output-low;
>> + power-source = <0>;
>> + };
>
> Drop the output-low, the consumers already take care of the state
For both enable and pwm?
>
> [...]
>
>> +&uart7 {
>> + /delete-property/interrupts;
>
> Let's add a space after the '/'
Will do
>
>> + interrupts-extended = <&intc GIC_SPI 608 IRQ_TYPE_LEVEL_HIGH>,
>> + <&tlmm 31 IRQ_TYPE_EDGE_FALLING>;
>> +
>> + pinctrl-1 = <&qup_uart7_sleep_cts>, <&qup_uart7_sleep_rts>,
>> <&qup_uart7_sleep_tx>, <&qup_uart7_sleep_rx>;
>
> And let's wrap this line
Sure
>
> [...]
>
>> +&usb_1 {
>> + dr_mode = "host";
>
> Does OTG not "just work"?
Is this a feature one would want on a laptop? On a phone for sure, but I
don't quite see the use case for the laptop to be a peripheral? But I
didn't try it, the USB basic setup was done by Jasper
>
> I'm assuming there's no pmic-glink on this device?
I'm not quite sure yet how the USB stuff works. For sure from
observation, USB-C only works when stuff was plugged-in at boot time
(UEFI?), and charger also only supplies any power (but not actually
charging) when plugged in at boot time.
Regards
Luca
>
> Konrad
