On Wed, Oct 14, 2026 at 04:31:17PM +0000, [email protected] wrote: > Thank you for your contribution! Sashiko AI review found 3 potential issue(s) > to consider: > - [High] dts: usb_1_qmpphy swaps vdda-phy and vdda-pll voltage supplies > - [Medium] dts: home_pin_a pinctrl incorrectly configures gpio6 instead of > gpio5 > - [Medium] dts: impossible 1.8V vin-supply for 3.3V fixed regulator > vreg_sys_bob_3p3 > -- > > commit 48f1c407e24f3899e533d5dddbd59a77b4901a02 > Author: Dmitry Baryshkov <[email protected]> > > arm64: dts: qcom: add device tree for SDM845-HDK > > This patch adds the device tree for the SDM845-HDK board, a development > platform utilizing the modem-less SDA845 SoC. It introduces initial support > for features like HDMI display, uSD, UFS, USB, and various onboard > peripherals. > > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-hdk.dts > > b/arch/arm64/boot/dts/qcom/sdm845-hdk.dts > > new file mode 100644 > > index 0000000000000..4dd426912d20f > > --- /dev/null > > +++ b/arch/arm64/boot/dts/qcom/sdm845-hdk.dts > > [ ... ] > > > + vreg_sys_bob_3p3: regulator-sys-bob { > > + compatible = "regulator-fixed"; > > + regulator-name = "sys_bob"; > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + > > + regulator-always-on; > > + regulator-boot-on; > > + > > + vin-supply = <&vreg_s4a_1p8>; > > + }; > > [Severity: Medium] > Is vreg_s4a_1p8 the correct vin-supply for this regulator? > > vreg_s4a_1p8 provides 1.8V, but vreg_sys_bob_3p3 is defined as a 3.3V fixed > regulator. A fixed regulator cannot step up a 1.8V input to 3.3V. > > Could this create an incorrect power dependency tree, potentially causing the > 1.8V supply to be kept awake unnecessarily or turned off while the 3.3V rail > is still needed?
This is the least awkward description. This regulator is powered by vph_pwr and enabled by S4A. Using S4A as vin-supply is the most logical way to express it. -- With best wishes Dmitry
