Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] arm64: dts: qcom: inconsistent SDHC_2 drive strength vs comment --
commit ad3a4fdbe0a1af267d2159b955cbbffe917a1e14 Author: Dmitry Baryshkov <[email protected]> arm64: dts: qcom: add device tree for SDM845-HDK Add device tree for the Qualcomm / Lantronix SDM845 HDK. This adds support for the development platform using the modem-less (SDA845) SoC, including peripherals like HDMI, DSPs, and USB. > diff --git a/arch/arm64/boot/dts/qcom/sdm845-hdk.dts > b/arch/arm64/boot/dts/qcom/sdm845-hdk.dts > new file mode 100644 > index 0000000000000..a2f139751ab6a > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sdm845-hdk.dts [ ... ] > + sdc2_default_state: sdc2-default-state { > + clk-pins { > + pins = "sdc2_clk"; > + bias-disable; > + > + /* > + * It seems that mmc_test reports errors if drive > + * strength is not 16 on clk, cmd, and data pins. > + */ > + drive-strength = <16>; > + }; > + > + cmd-pins { > + pins = "sdc2_cmd"; > + bias-pull-up; > + drive-strength = <10>; > + }; > + > + data-pins { > + pins = "sdc2_data"; > + bias-pull-up; > + drive-strength = <10>; > + }; [Severity: Low] Is this configuration intentional? The comment in the clk-pins block just above explicitly warns that mmc_test reports errors if drive strength is not 16 on clk, cmd, and data pins. However, cmd-pins and data-pins are configured with a drive strength of 10. Does the comment need updating, or should these pins be set to 16 to avoid potential mmc_test errors? > + }; [ ... ] -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=4
