[PATCH 1/9] backlight: qcom-wled: fix unbalanced OVP interrupt enable

[Dmitry Baryshkov]

If the bootloader leaves the WLED module enabled, the OVP interrupt is
left enabled at probe time. The first brightness update then schedules
wled_ovp_work(), which enables the interrupt for a second time and
triggers the "Unbalanced enable for IRQ" warning.

Track whether the driver has disabled the interrupt and only enable it
back in that case.

Fixes: 8663c188beea ("backlight: qcom-wled: Add auto string detection logic")
Assisted-by: LLM
Signed-off-by: Dmitry Baryshkov <dmitry.barysh...@oss.qualcomm.com>
---
 drivers/video/backlight/qcom-wled.c | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

diff --git a/drivers/video/backlight/qcom-wled.c 
b/drivers/video/backlight/qcom-wled.c
index 650dd95f06ef..f2e0430cccbc 100644
--- a/drivers/video/backlight/qcom-wled.c
+++ b/drivers/video/backlight/qcom-wled.c
@@ -199,6 +199,7 @@ struct wled {
        bool cabc_disabled;
        int short_irq;
        int ovp_irq;
+       bool ovp_irq_disabled;
 
        struct wled_config cfg;
        struct delayed_work ovp_work;
@@ -294,7 +295,11 @@ static void wled_ovp_work(struct work_struct *work)
 {
        struct wled *wled = container_of(work,
                                         struct wled, ovp_work.work);
-       enable_irq(wled->ovp_irq);
+
+       if (wled->ovp_irq_disabled) {
+               enable_irq(wled->ovp_irq);
+               wled->ovp_irq_disabled = false;
+       }
 }
 
 static int wled_module_enable(struct wled *wled, int val)
@@ -321,8 +326,11 @@ static int wled_module_enable(struct wled *wled, int val)
                         */
                        schedule_delayed_work(&wled->ovp_work, HZ / 100);
                } else {
-                       if (!cancel_delayed_work_sync(&wled->ovp_work))
+                       cancel_delayed_work_sync(&wled->ovp_work);
+                       if (!wled->ovp_irq_disabled) {
                                disable_irq(wled->ovp_irq);
+                               wled->ovp_irq_disabled = true;
+                       }
                }
        }
 
@@ -1649,8 +1657,10 @@ static int wled_configure_ovp_irq(struct wled *wled,
                return rc;
 
        /* Keep OVP irq disabled until module is enabled */
-       if (!(val & WLED3_CTRL_REG_MOD_EN_MASK))
+       if (!(val & WLED3_CTRL_REG_MOD_EN_MASK)) {
                disable_irq(wled->ovp_irq);
+               wled->ovp_irq_disabled = true;
+       }
 
        return 0;
 }

-- 
2.47.3