"Luca Ceresoli" <[email protected]> writes: > Hello Javier, > > On Thu Oct 15, 2026 at 12:47 PM CEST, Javier Martinez Canillas wrote:
[...] >>> >>> - regmap_read(ctx->regmap, IT66121_VENDOR_ID0_REG, &vendor_ids[0]); >>> - regmap_read(ctx->regmap, IT66121_VENDOR_ID1_REG, &vendor_ids[1]); >>> - regmap_read(ctx->regmap, IT66121_DEVICE_ID0_REG, &device_ids[0]); >>> - regmap_read(ctx->regmap, IT66121_DEVICE_ID1_REG, &device_ids[1]); >> >> You should probably drop these defines if will no longer be used. Instead, >> maybe you could define a IT66121_CHIP_ID_REGS_START or something like that? >> >> Although maybe is good to keep them as documentation? Not sure about this. > > I'd rather keep them for documentation if you don't mind. > Sure, I'm Ok with that. -- Best regards, Javier Martinez Canillas Core Platforms Red Hat
