Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] drm/panel: missing select DRM_KMS_HELPER in DRM_PANEL_NOVATEK_NT36850 --
commit 6d69498564f980cf8c931a0b5bc25de370ede1e6 Author: Dmitry Baryshkov <[email protected]> drm/panel: add Novatek NT36850 panel driver This commit adds a DRM panel driver for the Truly WQHD dual-DSI command mode panel built around the Novatek NT36850 display controller. > diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig > index cbdf7b8f7f7af..2cb49e6595d64 100644 > --- a/drivers/gpu/drm/panel/Kconfig > +++ b/drivers/gpu/drm/panel/Kconfig > @@ -697,6 +697,16 @@ config DRM_PANEL_NOVATEK_NT36672E > LCD panel module. The panel has a resolution of 1080x2408 and uses 24 > bit > RGB per pixel. > > +config DRM_PANEL_NOVATEK_NT36850 > + tristate "Novatek NT36850 panel driver" > + depends on OF > + depends on DRM_MIPI_DSI > + depends on BACKLIGHT_CLASS_DEVICE > + help > + Say Y here if you want to enable support for the panels built > + around the Novatek NT36850 display controller, such as some > + Truly panels used in Qualcomm development kits. > + [Severity: Low] Should DRM_PANEL_NOVATEK_NT36850 select DRM_KMS_HELPER here? In drivers/gpu/drm/panel/panel-novatek-nt36850.c, nt36850_get_modes() calls drm_connector_helper_get_modes_fixed(), which is built as part of drm_kms_helper.o under CONFIG_DRM_KMS_HELPER: > diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36850.c > b/drivers/gpu/drm/panel/panel-novatek-nt36850.c > new file mode 100644 > index 0000000000000..0d1eeba539dbd > --- /dev/null > +++ b/drivers/gpu/drm/panel/panel-novatek-nt36850.c [ ... ] > +static int nt36850_get_modes(struct drm_panel *panel, > + struct drm_connector *connector) > +{ > + struct panel_info *pinfo = to_panel_info(panel); > + > + connector->display_info.bpc = pinfo->desc->bpc; > + > + return drm_connector_helper_get_modes_fixed(connector, > pinfo->desc->mode); > +} [ ... ] When CONFIG_DRM_PANEL_NOVATEK_NT36850=y and CONFIG_DRM_KMS_HELPER=m (or n), could linking vmlinux fail with an undefined reference to drm_connector_helper_get_modes_fixed? [ ... ] > +module_mipi_dsi_driver(nt36850_driver); > + > +MODULE_AUTHOR("Dmitry Baryshkov <[email protected]>"); > +MODULE_DESCRIPTION("DRM driver for Novatek NT36850 based MIPI DSI panels"); > +MODULE_LICENSE("GPL"); -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=2
