Hi

Am 14.10.26 um 19:26 schrieb Maxime Ripard:
The aspeed connector implementation uses the deprecated
drm_atomic_helper_connector_reset() as its reset hook.

Switch to drm_atomic_helper_connector_create_state() instead.

Signed-off-by: Maxime Ripard <[email protected]>
---
Cc: Andrew Jeffery <[email protected]>
Cc: Joel Stanley <[email protected]>
---
  drivers/gpu/drm/aspeed/aspeed_gfx_out.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/aspeed/aspeed_gfx_out.c 
b/drivers/gpu/drm/aspeed/aspeed_gfx_out.c
index 78775e0c853f..83bf5561bf81 100644
--- a/drivers/gpu/drm/aspeed/aspeed_gfx_out.c
+++ b/drivers/gpu/drm/aspeed/aspeed_gfx_out.c
@@ -19,11 +19,11 @@ drm_connector_helper_funcs 
aspeed_gfx_connector_helper_funcs = {
  };
static const struct drm_connector_funcs aspeed_gfx_connector_funcs = {
        .fill_modes             = drm_helper_probe_single_connector_modes,
        .destroy                = drm_connector_cleanup,
-       .reset                  = drm_atomic_helper_connector_reset,
+       .atomic_create_state = drm_atomic_helper_connector_create_state,

I think that the patch should respect the alignment here (and maybe in other patches). Apart from that

Reviewed-by: Thomas Zimmermann <[email protected]>

        .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
        .atomic_destroy_state   = drm_atomic_helper_connector_destroy_state,
  };
int aspeed_gfx_create_output(struct drm_device *drm)


--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Stefan Gaiser, Jochen Jaser, Abhinav Puri, (HRB 36809, AG Nürnberg)


Reply via email to