Hi Thomas, Thanks for your review
On Tue, Oct 20, 2026 at 03:49:56PM +0200, Thomas Zimmermann wrote: > Am 14.10.26 um 19:27 schrieb Maxime Ripard: > > The sysfb connector implementation uses the deprecated > > drm_atomic_helper_connector_reset() as its reset hook. > > > > Switch to drm_atomic_helper_connector_create_state() instead. > > > > Signed-off-by: Maxime Ripard <[email protected]> > > --- > > Cc: Javier Martinez Canillas <[email protected]> > > --- > > drivers/gpu/drm/sysfb/drm_sysfb_helper.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/sysfb/drm_sysfb_helper.h > > b/drivers/gpu/drm/sysfb/drm_sysfb_helper.h > > index c043428e02fd..6dab27b41c08 100644 > > --- a/drivers/gpu/drm/sysfb/drm_sysfb_helper.h > > +++ b/drivers/gpu/drm/sysfb/drm_sysfb_helper.h > > @@ -192,11 +192,11 @@ int drm_sysfb_connector_helper_get_modes(struct > > drm_connector *connector); > > #define DRM_SYSFB_CONNECTOR_HELPER_FUNCS \ > > .get_modes = drm_sysfb_connector_helper_get_modes > > #define DRM_SYSFB_CONNECTOR_FUNCS \ > > - .reset = drm_atomic_helper_connector_reset, \ > > + .atomic_create_state = drm_atomic_helper_connector_create_state, \ > > I'm sort of pedantic about this: I think fields should be initialized in the > order they appear in the declaration. atomic_create_state should therefore > go before atomic_duplicate state. Here and everywhere else. Apart from that This patch is particular is now merged, but I've updated all the other patches to reflect that. Maxime
signature.asc
Description: PGP signature
