On Mon, Oct 19, 2026 at 12:40:58PM -0700, John Harrison wrote: > On 10/19/26 06:12, Dmitry Baryshkov wrote: > > Drivers using drm_writeback_connector_init() / _with_encoder() don't > > perform cleanup in a manner similar to drmm_writeback_connector_init() > > (see drm_writeback_connector_cleanup()). Enough of the drivers don't use > > the encoder embedded into the drm_writeback connector. In preparation > > to further rework of the WB connectors (as planned to enable WB for i915 > > / xe drivers, which would move drm_writeback_connector to be a field > > inside drm_connector instead of subclassing it) remove the drm_encoder > > wrapped in struct drm_writeback_connector. Rename the > > drm_writeback_connector_init_with_encoder() to > > drm_writeback_connector_init() > > and copy drmm_writeback_connector_init() interface. Then, with the > > encoder being gone, handle proper cleanup of writeback data in > > drm_connector_cleanup(). > > > > --- > > Changes in v7: > > - Significantly reworked series, no longer insisting on using drmm. > Is there an intent to move everyone over to the drmm version in a future > patch set? Or is the plan to give up on that as being just too complicated > for the benefit?
I tried doing that in the previous iterations. I don't think we should enforce that change as a part of the framework. It would complicate the review. Individual driver maintainers might perform this change on their own later on. -- With best wishes Dmitry
