On Thu, Oct 22, 2026 at 05:31:05PM +0200, Lars Rask wrote: > From: Lars Rask <[email protected]> > > Made additions to st7571 display driver to support st75156. > > Signed-off-by: Lars Rask <[email protected]> > ---
Please organize the patch documenting the compatible (DT bindings) before the patch using that compatible. See also: https://elixir.bootlin.com/linux/v6.14-rc6/source/Documentation/devicetree/bindings/submitting-patches.rst#L46 > drivers/gpu/drm/sitronix/st7571-spi.c | 118 +++++++++- > drivers/gpu/drm/sitronix/st7571.c | 420 > +++++++++++++++++++++++++++++++++- > drivers/gpu/drm/sitronix/st7571.h | 20 ++ > 3 files changed, 549 insertions(+), 9 deletions(-) ... > + > static int st7571_spi_probe(struct spi_device *spi) > { > struct st7571_device *st7571; > struct regmap *regmap; > + struct spi_device_data *spi_data; > + > + spi_data = devm_kzalloc(&spi->dev, sizeof(*spi_data), GFP_KERNEL); > + if (IS_ERR(spi_data)) > + return dev_err_probe(&spi->dev, PTR_ERR(regmap), > + "Failed to initialize spi data\n"); I do not see how you initialize spi data here, so this is just incorrect error message. Regardless, driver NEVER prints error messages for allocation. Best regards, Krzysztof
