On Tue, Oct 27, 2026 at 01:05:55PM +0100, Christian König wrote: > On 10/26/26 06:36, Alistair Popple wrote: > > From: Jason Gunthorpe <[email protected]> > > > > This map function only works with SGT importers. > > > > Signed-off-by: Jason Gunthorpe <[email protected]> > > [ also rename the io_uring zcrx caller, which the unmap rename > > used to pick up, so that this commit builds with CONFIG_IO_URING_ZCRX - > > apopple ] > > Signed-off-by: Alistair Popple <[email protected]> > > I would make that the first patch in the set since dropping sgt from > the interface is probably something everybody can agree on. > > And sqash that together with renaming dma_buf_unmap_attachment(). > > Regarding the new name I think dma_buf_sgt_(un)map_attachment() is a > bit long and has the sgt at the wrong location. > > I would name the functions dma_buf_map_sgt() and dma_buf_unmap_sgt().
I was going for a namespace 'dma_buf_sgt_X' would capture all the functions related to the sgt mapping type and so on for other types. Jason
