On Tue, Oct 27, 2026 at 11:00:56AM -0400, [email protected] wrote: > From: Frank Li <[email protected]> > > Add lcdif support for i.MX8QXP and i.MX8DXL.
The commit message is incomplete. It doesn't mention why you needed to delete the nodes in imx8qm-ss-dma.dtsi. I see you deleted those because Sahiko suggested but it would be worth adding the reason in the commit message as well. > > Signed-off-by: Frank Li <[email protected]> > --- > change in v4 > - delete adma_lcdif and lcd_clk_lpcg (sashiko AI) > --- > arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi | 29 > ++++++++++++++++++++++ > arch/arm64/boot/dts/freescale/imx8dxl-ss-adma.dtsi | 11 ++++++++ > arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi | 2 ++ > 3 files changed, 42 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi > b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi > index 4de78f870c05c..87082c3fa9338 100644 > --- a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi > @@ -149,6 +149,24 @@ lpuart3: serial@5a090000 { > status = "disabled"; > }; > > + adma_lcdif: lcdif@5a180000 { > + compatible = "fsl,imx8qxp-lcdif", "fsl,imx6sx-lcdif"; > + reg = <0x5a180000 0x10000>; > + clocks = <&lcd_clk_lpcg IMX_LPCG_CLK_0>, > + <&lcd_clk_lpcg IMX_LPCG_CLK_4>, > + <&clk IMX_SC_R_LCD_0 IMX_SC_PM_CLK_MISC0>; > + clock-names = "pix", "axi", "disp_axi"; > + assigned-clocks = <&clk IMX_SC_R_LCD_0 IMX_SC_PM_CLK_PER>, > + <&clk IMX_SC_R_LCD_0 IMX_SC_PM_CLK_MISC0>, > + <&clk IMX_SC_R_ELCDIF_PLL IMX_SC_PM_CLK_PLL>; > + assigned-clock-parents = <&clk IMX_SC_R_ELCDIF_PLL > IMX_SC_PM_CLK_PLL>, > + <&clk IMX_SC_R_LCD_0 > IMX_SC_PM_CLK_BYPASS>; > + assigned-clock-rates = <0>, <24000000>, <804000000>; > + interrupts = <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>; > + power-domains = <&pd IMX_SC_R_LCD_0>; > + status = "disabled"; According to the DTS coding style you should add a blank line before 'status' line if there is content above it. With the above issues addressed: Acked-by: Laurentiu Palcu <[email protected]> -- Thanks, Laurentiu
