On Wed, Oct 28, 2026 at 11:51:44AM +0200, Vladimir Zapolskiy wrote: > The reset GPIO of NT36672E panels has been described as active high since > the binding was added, also see the example and the QCM6490 IDP board > device tree, however actually it serves as the active low signal, also > panel-common.yaml expects active low reset GPIOs to be described as such. > > Document the active high description of the reset GPIO explicitly as > the exceptional deviation from the actual signal polarity, any new devices > will use it in the same way as the existing ones. > > Signed-off-by: Vladimir Zapolskiy <[email protected]> > --- > .../bindings/display/panel/novatek,nt36672e.yaml | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git > a/Documentation/devicetree/bindings/display/panel/novatek,nt36672e.yaml > b/Documentation/devicetree/bindings/display/panel/novatek,nt36672e.yaml > index dc4672f3d01d..45743376995b 100644 > --- a/Documentation/devicetree/bindings/display/panel/novatek,nt36672e.yaml > +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt36672e.yaml > @@ -24,7 +24,14 @@ properties: > avdd-supply: true > avee-supply: true > port: true > - reset-gpios: true > + reset-gpios: > + maxItems: 1 > + description: > + GPIO connected to the reset pin of the panel. The GPIO must be > described > + as active high (GPIO_ACTIVE_HIGH), the asserted state releases the > panel
I disagree that it has to be active high, because, since we do not represent pin inverters in DT, it depends on board layout. Wording would need to be correct if this stays. > + from reset. Note that the RESET_N pin is in fact an active low signal, > + the inverted description is kept for compatibility with existing device > + trees, while it deviates from the convention of panel-common.yaml. We might fix it at some point, so not sure if it is worth documenting in the binding. And what about usage of this binding in other projects which implement it correctly? Best regards, Krzysztof
