Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] drm/atomic_sro: missing EXPORT_SYMBOL() on drm_atomic_sro_state_get_device() --
commit 272e19a2c59ccd440923a43421c7657b21dcc87e Author: Maxime Ripard <[email protected]> drm/atomic_sro: Create drm_atomic_sro_state container This commit introduces the struct drm_atomic_sro_state container to hold hardware readout states for planes, CRTCs, connectors, and private objects, along with helper functions to allocate, free, print, and access those states. > diff --git a/drivers/gpu/drm/drm_atomic_state_readout.c > b/drivers/gpu/drm/drm_atomic_state_readout.c > new file mode 100644 > index 0000000000000..2f8df00e993eb > --- /dev/null > +++ b/drivers/gpu/drm/drm_atomic_state_readout.c > @@ -0,0 +1,475 @@ [ ... ] > +/** > + * drm_atomic_sro_state_get_device - get the DRM device from an SRO state > + * @state: SRO state > + * > + * RETURNS: > + * > + * The &struct drm_device associated with the SRO state. > + */ > +struct drm_device * > +drm_atomic_sro_state_get_device(struct drm_atomic_sro_state *state) > +{ > + return state->dev; > +} [Severity: Low] Should drm_atomic_sro_state_get_device() have an EXPORT_SYMBOL() here? struct drm_atomic_sro_state is an opaque structure defined privately in drivers/gpu/drm/drm_atomic_state_readout.c, and drm_atomic_sro_state_get_device() is declared in include/drm/drm_atomic_state_readout.h alongside the other public SRO state helpers. Unlike all of the other public functions in this file, it is not exported with EXPORT_SYMBOL(drm_atomic_sro_state_get_device). When a loadable module calls drm_atomic_sro_state_get_device(), such as the KUnit test in drivers/gpu/drm/tests/drm_atomic_state_readout_test.c when built with CONFIG_DRM_KUNIT_TEST=m, will this cause a modpost undefined symbol failure? -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=10
