Sparse (W=1) builds fail because `SIZE_CHECK(struct rogue_fwif_hwrtdata,
384)` expects 384 bytes, but the compiler generates a 336-byte
structure.
This is due to an alignment conflict: the inner member `cleanup_state`
requires 64-byte alignment, but the outer struct is explicitly marked
`__aligned(8)`.
While a non-sparse build implicitly pads the size to a multiple of 64, a
sparse build strictly respects the 8-byte outer alignment, resulting in
a size mismatch.
Fix this by aligning the entire structure to 64 bytes, which resolves
the contradiction and forces the correct 384 byte size on all builds.
Fixes: a26f067feac1 ("drm/imagination: Add FWIF headers")
Reported-by: kernel test robot <[email protected]>
Closes:
https://lore.kernel.org/oe-kbuild-all/[email protected]/
Reviewed-by: Matt Coster <[email protected]>
Reviewed-by: Luigi Santivetti <[email protected]>
Signed-off-by: Michal Wilczynski <[email protected]>
---
Changes in v4:
- Reworded the commit message to state that the size mismatch is reported
by sparse (W=1) builds, not by regular GCC builds on RISC-V, as
requested in v3 review. The commit message rework announced for v2 was
never actually applied, so v2 and v3 went out with the v1 message.
- Picked up Matt's Reviewed-by from v1.
- No changes to the code.
- Rebased on latest master.
- Link to v3:
https://lore.kernel.org/r/[email protected]
Changes in v3:
- Cleaned up the changelog section by removing the accidental b4
"EDITME" template from v2.
- No changes to the code or commit message.
- Rebased patch on latest master.
Changes in v2:
- Expanded the commit message to properly explain the root cause of the
GCC alignment conflict on RISC-V vs ARM64, based on v1 feedback.
- No changes to the code.
---
drivers/gpu/drm/imagination/pvr_rogue_fwif.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/imagination/pvr_rogue_fwif.h
b/drivers/gpu/drm/imagination/pvr_rogue_fwif.h
index
5d590c4c25663e431601dd26944465b62c31526b..2f8daa93c9e6832bbeec7460275c4b803792cb02
100644
--- a/drivers/gpu/drm/imagination/pvr_rogue_fwif.h
+++ b/drivers/gpu/drm/imagination/pvr_rogue_fwif.h
@@ -2174,7 +2174,7 @@ struct rogue_fwif_hwrtdata {
bool geom_caches_need_zeroing __aligned(4);
struct rogue_fwif_cleanup_ctl cleanup_state __aligned(64);
-} __aligned(8);
+} __aligned(64);
/*
******************************************************************************
---
base-commit: d135ab453a7400a34930bdda1ef4bdc8acfac80e
change-id: 20251222-fix_imagination-8ef0c94122c4
Best regards,
--
Michal Wilczynski <[email protected]>
