Hi, On 29-Oct-26 1:16 AM, Rob Clark wrote: > It isn't _necessarily_ an error, the driver will try again each time the > device file is opened. But if you don't have GPU fw in the initrd, you > end up seeing this error message at least once. Which seems to confuse > users. So try to re-word it slightly. > > Signed-off-by: Rob Clark <[email protected]>
Thanks, patch looks good to me: Reviewed-by: Hans de Goede <[email protected]> Regards, Hans > --- > drivers/gpu/drm/msm/adreno/adreno_gpu.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c > b/drivers/gpu/drm/msm/adreno/adreno_gpu.c > index 5832dc25d6bf..6db6cb7eb287 100644 > --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c > +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c > @@ -558,7 +558,7 @@ adreno_request_fw(struct adreno_gpu *adreno_gpu, const > char *fwname) > adreno_gpu->fwloc = FW_LOCATION_NEW; > goto out; > } else if (adreno_gpu->fwloc != FW_LOCATION_UNKNOWN) { > - DRM_DEV_ERROR(drm->dev, "failed to load %s: %d\n", > + DRM_DEV_INFO(drm->dev, "failed to load %s: %d (will try > again later)\n", > newname, ret); > fw = ERR_PTR(ret); > goto out; > @@ -578,7 +578,7 @@ adreno_request_fw(struct adreno_gpu *adreno_gpu, const > char *fwname) > adreno_gpu->fwloc = FW_LOCATION_LEGACY; > goto out; > } else if (adreno_gpu->fwloc != FW_LOCATION_UNKNOWN) { > - DRM_DEV_ERROR(drm->dev, "failed to load %s: %d\n", > + DRM_DEV_INFO(drm->dev, "failed to load %s: %d (will try > again later)\n", > fwname, ret); > fw = ERR_PTR(ret); > goto out; > @@ -599,14 +599,14 @@ adreno_request_fw(struct adreno_gpu *adreno_gpu, const > char *fwname) > adreno_gpu->fwloc = FW_LOCATION_HELPER; > goto out; > } else if (adreno_gpu->fwloc != FW_LOCATION_UNKNOWN) { > - DRM_DEV_ERROR(drm->dev, "failed to load %s: %d\n", > + DRM_DEV_INFO(drm->dev, "failed to load %s: %d (will try > again later)\n", > newname, ret); > fw = ERR_PTR(ret); > goto out; > } > } > > - DRM_DEV_ERROR(drm->dev, "failed to load %s\n", fwname); > + DRM_DEV_INFO(drm->dev, "failed to load %s (will try again later)\n", > fwname); > fw = ERR_PTR(-ENOENT); > out: > kfree(newname);
