This is another series of fixes to the ethosu driver. It's mostly probe error paths and cmd stream validation fixes. It's a mixture of AI reported issues, different solutions to other posted issues and fixes[1] and my own fixes. The last 2 patches are additional operation support.
The series adds rejecting OFM tranpose in cmd stream, but then a later patch adds support for it. I did this so the rejection can be backported, but maybe supporting OFM transpose is small enough that it should just be backported too? Sashiko keeps raising issues about IRQs, but the h/w only generates an interrupt if a job was submitted. The scenarios sashiko talks about are not possible. Rob [1] https://lore.kernel.org/all/[email protected] Signed-off-by: Rob Herring (Arm) <[email protected]> --- Changes in v4: - More patches added for existing issues raised by Sashiko in v3 and local runs - Combined the 2 patches for unknown cmds and unhandled parameters into one patch - Link to v3: https://patch.msgid.link/[email protected] Changes in v3: - Address Sashiko comments - Another runtime-PM fix for driver remove() - Add a fix for NHCWB16 bounds calculation - Link to v2: https://patch.msgid.link/[email protected] Changes in v2: - Dropped first 5 patches which are already applied - Patches 11-17 and 19 are new patches with more cmd stream validation - Add fix to diable clocks on PM setup failure - Rework the runtime-PM to suspend after initialization and before drm_dev_register(). This simplifies the error clean-up in probe. - Handle quiescing jobs before scheduler teardown - Rework the cmd stream register initialization tracking to use a bitmap of registers instead of relying on initial state values. - Handle U85 DMA 2D/3D modes correctly - Link to v1: https://patch.msgid.link/[email protected] --- Rob Herring (Arm) (31): accel: ethosu: Suspend after initialization accel: ethosu: Ensure suspended on removal accel: ethosu: Fix probe error cleanup accel: ethosu: Disable clocks on PM setup failure accel: ethosu: Quiesce jobs before scheduler teardown accel: ethosu: Fix runtime PM get error handling accel: ethosu: Limit perfmon counters to UAPI accel: ethosu: Serialize job completion accel: ethosu: Guard operations after unplug accel: ethosu: Keep scheduler after unplug accel: ethosu: Clear SRAM before submission accel: ethosu: Validate timeout command offset accel: ethosu: Prevent command stream export accel: ethosu: Move DMA mode to src/dst struct accel: ethosu: Track command stream register setup accel: ethosu: Factor buffer bounds checks accel: ethosu: Fix NHCWB16 bounds calculation accel: ethosu: Validate secondary streams accel: ethosu: Reject unsupported commands and params accel: ethosu: Validate all feature map tiles accel: ethosu: Account for feature map element size accel: ethosu: Validate convolution parameter accel: ethosu: Account for kernel dilation in IFM size accel: ethosu: Validate accumulator input accel: ethosu: Restrict dynamic IFM2 weights accel: ethosu: Split U65 and U85 DMA length validation accel: ethosu: Validate OFM transpose accel: ethosu: Validate resize operations accel: ethosu: Ensure cmd stream is multiple of 4 bytes accel: ethosu: Require active weight streams setup accel: ethosu: Support U85 IFM upscaling drivers/accel/ethosu/ethosu_device.h | 40 ++ drivers/accel/ethosu/ethosu_drv.c | 56 +- drivers/accel/ethosu/ethosu_drv.h | 6 + drivers/accel/ethosu/ethosu_gem.c | 951 +++++++++++++++++++++++++++++++--- drivers/accel/ethosu/ethosu_job.c | 236 +++++++-- drivers/accel/ethosu/ethosu_job.h | 5 +- drivers/accel/ethosu/ethosu_perfmon.c | 123 +++-- 7 files changed, 1236 insertions(+), 181 deletions(-) --- base-commit: 9a96e169c9267af918d28fb291df948d83112807 change-id: 20260827-ethosu-fixes-ee58386e9000 Best regards, -- Rob Herring (Arm) <[email protected]>
