Hi, On Mon, Oct 12, 2026 at 9:35 PM Akash Sukhavasi <[email protected]> wrote: > > @@ -535,27 +533,17 @@ static int ltk500hd1829_prepare(struct drm_panel *panel) > /* tRT: >= 5ms */ > usleep_range(5000, 6000); > > - for (i = 0; i < ctx->panel_desc->num_init; i++) { > - ret = mipi_dsi_generic_write(dsi, &ctx->panel_desc->init[i], > + for (i = 0; i < ctx->panel_desc->num_init; i++) > + mipi_dsi_generic_write_multi(&dsi_ctx, > &ctx->panel_desc->init[i], > sizeof(struct ltk500hd1829_cmd)); > - if (ret < 0) { > - dev_err(panel->dev, "failed to write init cmds: > %d\n", ret); > - goto disable_iovcc; > - } > - } > - > - ret = mipi_dsi_dcs_exit_sleep_mode(dsi); > - if (ret < 0) { > - dev_err(panel->dev, "failed to exit sleep mode: %d\n", ret); > - goto disable_iovcc; > - } > > + mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx); > /* 120ms to exit sleep mode */ > - msleep(120); > + mipi_dsi_msleep(&dsi_ctx, 120); > + mipi_dsi_dcs_set_display_on_multi(&dsi_ctx); > > - ret = mipi_dsi_dcs_set_display_on(dsi); > - if (ret < 0) { > - dev_err(panel->dev, "failed to set display on: %d\n", ret); > + if (dsi_ctx.accum_err) { > + ret = dsi_ctx.accum_err; > goto disable_iovcc;
nit: In the whole series, I probably would have removed the whole "disable_iovcc" label and then changed the above to: if (!dsi_ctx.accum_err) return 0; That being said, it's a matter of style and what you have here is also fine. The patch looks good to me. Reviewed-by: Douglas Anderson <[email protected]> Everything being equal, I'd land it in ~1 week or so.
