Maxime Ripard <[email protected]> writes:
Hello Maxime,
> The ssd130x_crtc_create_state() implementation warns when the CRTC
> already has a state, assuming that atomic_create_state would only ever
> be called at initialization time to allocate the initial state.
>
> However, atomic_create_state is documented to have no side effect and
> can be called at runtime, so that assumption doesn't hold and the WARN
> is a side effect in itself.
>
> Let's drop the WARN, along with the comment documenting that
> assumption.
>
> Fixes: 1345de7fe9114 ("drm/solomon: ssd130x: Convert to atomic_create_state")
> Signed-off-by: Maxime Ripard <[email protected]>
>
> ---
>
> To: Javier Martinez Canillas <[email protected]>
> ---
> drivers/gpu/drm/solomon/ssd130x.c | 3 ---
> 1 file changed, 3 deletions(-)
>
Reviewed-by: Javier Martinez Canillas <[email protected]>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
