> The panel is used directly, without the panel bridge, so nothing sets > its orientation on the connector apart from the workaround in the > get_modes() of some panel drivers, which runs too late. > > Assisted-by: LLM > Signed-off-by: Dmitry Baryshkov <[email protected]> > > diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c > b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c > index 407834a03b63..91ce1a877bf8 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c > @@ -525,6 +525,11 @@ static int anx6345_bridge_attach(struct drm_bridge > *bridge, > > anx6345->connector.polled = DRM_CONNECTOR_POLL_HPD; > > + err = drm_connector_set_orientation_from_panel(&anx6345->connector, > + anx6345->panel); > + if (err) > + goto connector_cleanup;
Muy understanding is that this driver, and those in patches 15-21, should be eventually converted to use the bridge API instead of the panel API, but that's a significant work and so for now this small change is enough to get to patch 22 (workaround removal). Correct? Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
