On 11/2/26 00:44, [email protected] wrote:
[Severity: Medium] Should rear_cam_sensor reference ADC5_GPIO2_100K_PU instead of ADC5_GPIO6_100K_PU here?On PM6150L, physical pin gpio6 is routed to ADC5_GPIO2_100K_PU (0x53), and under &pm6150l_adc below the rear camera thermistor channel is defined as:
Ah yes, looks like I confused gpio6 from downstream DT and gpio2 from include/dt-bindings/iio/qcom,spmi-vadc.h
Will fix with v4...
[Severity: Low]
This isn't a runtime bug, but there are a few patch split and style issues
across this change:
1. Earlier in the series, commit ff24120a08d6 ("arm64: dts: qcom: sm6350-lena:
Add PMK8350 thermals") added xo-thermal, and the next commit f17bc49f693d
("arm64: dts: qcom: sm6350-lena: Add PM7250B thermals") accidentally removed
it. Re-adding xo-thermal here puts a PMK8350 thermal zone into the PM6150L
thermal patch. Could xo-thermal be kept in the PMK8350 patch instead?
The bot already commented this on the other patch... I know, rebase mishap, fixed...
2. The newly added dt-bindings/gpio/gpio.h and dt-bindings/input/input.h includes at the top of the file do not appear to be used by this patch.
Oh yes, will remove.
3. Label references at the bottom of the file are sorted alphabetically, so should &pm6150l_gpios be placed after &pm6150l_flash rather than before &pm6150l_adc?
Oh yes, will re-train the alphabet and fix that as well... :)
4. The closing brace of rear-cam-flash-therm@2 has an extra tab of indentation.
also fixed in v4... -- erebion XMPP: [email protected] My languages: German, English, Swedish, Norwegian, DanishYes, I'm a language nerd. Feel free to write to me in any of the aforementioned languages.
OpenPGP_signature.asc
Description: OpenPGP digital signature
