Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] backlight: ktd3137: use named initializer in ktd3137_ids --
commit d3260d17f4919396b8ff6c1268dffef7e26e01cf Author: Roman Vivchar <[email protected]> backlight: add ktd3137 support This commit adds a backlight driver for the Kinetic KTD3137 display backlight IC. > diff --git a/drivers/video/backlight/ktd3137.c > b/drivers/video/backlight/ktd3137.c > new file mode 100644 > index 0000000000000..a3ff334b8d460 > --- /dev/null > +++ b/drivers/video/backlight/ktd3137.c > @@ -0,0 +1,262 @@ [ ... ] > +static const struct i2c_device_id ktd3137_ids[] = { > + { "ktd3137" }, > + { } > +}; [Severity: Low] This isn't a bug, but in drivers/video/backlight/ktd3137.c, could the struct i2c_device_id entry in ktd3137_ids[] use a named initializer ({ .name = "ktd3137" }) instead of a positional initializer to match I2C subsystem conventions? -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=2
