Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] drm/xe/uapi: inaccurate comment and missing kernel-doc for NUMA_NODE property --
commit 3afc5386219df9a82a534e249ba21444e34868d6 Author: Himal Prasad Ghimiray <[email protected]> drm/xe/uapi: Add GEM_CREATE NUMA node placement property This commit adds the DRM_XE_GEM_CREATE_SET_PROPERTY_NUMA_NODE property to struct drm_xe_gem_create so userspace can specify the host NUMA node for system-memory buffer objects. > diff --git a/include/uapi/drm/xe_drm.h b/include/uapi/drm/xe_drm.h > index 578f0c1eb43e8..0b39081330eeb 100644 > --- a/include/uapi/drm/xe_drm.h > +++ b/include/uapi/drm/xe_drm.h > @@ -843,6 +843,13 @@ struct drm_xe_device_query { > struct drm_xe_gem_create { > #define DRM_XE_GEM_CREATE_EXTENSION_SET_PROPERTY 0 > #define DRM_XE_GEM_CREATE_SET_PROPERTY_PXP_TYPE 0 > + /* > + * Host NUMA node (as a signed value) to allocate system-memory > + * backing pages from. Only honored for objects with a system-memory > + * placement; ignored for VRAM-only objects. Use a value < 0 to keep > + * the default device-local placement. > + */ > +#define DRM_XE_GEM_CREATE_SET_PROPERTY_NUMA_NODE 1 [Severity: Low] In the follow-up commit ("drm/xe/uapi: Wire up GEM_CREATE NUMA node placement handler"), gem_create_parse_numa_node() in drivers/gpu/drm/xe/xe_bo.c checks whether XE_BO_FLAG_SYSTEM is set and returns -EINVAL when a non-negative NUMA node is requested on a VRAM-only BO, rather than ignoring the property. Should this comment say that specifying a NUMA node is rejected for VRAM-only objects instead of ignored? Also, struct drm_xe_gem_create documents its DRM_XE_GEM_CREATE_EXTENSION_SET_PROPERTY properties in the kernel-doc comment block above the struct definition alongside DRM_XE_GEM_CREATE_SET_PROPERTY_PXP_TYPE so that they are included in Documentation/gpu/driver-uapi.rst. Should the description for DRM_XE_GEM_CREATE_SET_PROPERTY_NUMA_NODE be moved into that kernel-doc list above struct drm_xe_gem_create? -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=6
