xe_log_err() expects an error code, but in the case 0 branch of
handle_page_offline(), 'ret' is zero. Passing zero to a function
expecting an error code is incorrect.
Switch to xe_log_info() instead so that an error code is not
expected and zero is not passed.
Fixes: 12b427cf8bb0 ("drm/xe/xe_ras: Handle page offline requests for device
memory ecc errors")
Signed-off-by: Ethan Tidmore <[email protected]>
---
drivers/gpu/drm/xe/xe_ras.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_ras.c b/drivers/gpu/drm/xe/xe_ras.c
index db3cbc186a51..7942a2a48887 100644
--- a/drivers/gpu/drm/xe/xe_ras.c
+++ b/drivers/gpu/drm/xe/xe_ras.c
@@ -304,9 +304,9 @@ static int handle_page_offline(struct xe_device *xe, u64
page_address, bool noti
switch (ret) {
case 0:
action = XE_RAS_PAGE_ACTION_REMOVE;
- xe_log_err(xe, DEVICE_MEMORY, ret,
- "Poison detected at physical address 0x%llx, page
soft-offlined\n",
- page_address);
+ xe_log_info(xe, DEVICE_MEMORY,
+ "Poison detected at physical address 0x%llx, page
soft-offlined\n",
+ page_address);
break;
case -EIO:
xe_log_err(xe, DEVICE_MEMORY, ret,
--
Thanks,
ET
https://github.com/sponsors/ethantidmore
