Hi Joshua, thanks for the patch.
However, a fix for the same issue had been in the making for some time. It's
already been upstreamed:
e9672bf9382f ("drm/panfrost: Fix PM refcnt and autosuspend issues at device
probe/remove")
Kind Regards,
Adrian
On 16.09.2026 07:50, Joshua Crofts wrote:
> panfrost_remove() and panfrost_probe() disable PM runtime on teardown or
> failure but don't call the pm_runtime_dont_use_autosuspend() function,
> causing potential resource leaks.
>
> Add the missing function calls.
>
> Found using Coccinelle.
>
> Fixes: 5c0c825ae4c6 ("drm/panfrost: Replace DRM driver allocation method with
> newer one")
> Cc: <[email protected]>
> Signed-off-by: Joshua Crofts <[email protected]>
> ---
> drivers/gpu/drm/panfrost/panfrost_drv.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c
> b/drivers/gpu/drm/panfrost/panfrost_drv.c
> index 36cc2e67a308..74e8e5783f9b 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_drv.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c
> @@ -1012,6 +1012,7 @@ static int panfrost_probe(struct platform_device *pdev)
> err_out2:
> drm_dev_unregister(&pfdev->base);
> err_out1:
> + pm_runtime_dont_use_autosuspend(pfdev->base.dev);
> pm_runtime_disable(pfdev->base.dev);
> panfrost_device_fini(pfdev);
> pm_runtime_set_suspended(pfdev->base.dev);
> @@ -1027,6 +1028,7 @@ static void panfrost_remove(struct platform_device
> *pdev)
> panfrost_gem_shrinker_cleanup(&pfdev->base);
>
> pm_runtime_get_sync(pfdev->base.dev);
> + pm_runtime_dont_use_autosuspend(pfdev->base.dev);
> pm_runtime_disable(pfdev->base.dev);
> panfrost_device_fini(pfdev);
> pm_runtime_set_suspended(pfdev->base.dev);
> --
> 2.47.3
