This fix is also needed for stable kernels (5.4+). The bug exists
since the legacy DCE audio path was introduced and affects users on
LTS 5.4 kernels with AMD Southern Islands / CIK / VI GPUs connected
to displays without audio support.

Could you please add the following line when applying?

  Cc: [email protected] # 5.4+

Thanks.









At 2026-11-02 17:49:29, [email protected] wrote:
>From: renpanpan <[email protected]>
>
>The amdgpu legacy DCE audio path (dce_v6/v8/v10) unconditionally calls
>audio_enable(pin, true) at the end of afmt_setmode(), regardless of
>whether the connected display advertises audio support in its EDID.
>
>This causes a phantom HDMI audio output to appear for displays that
>have no audio capability (no basic audio bit, no Audio Data Block in
>EDID), because the GPU sets the AUDIO_ENABLED register bit, which
>drives the HDA codec's ELDV pin sense, making the codec report the
>jack as audio-available.
>
>The radeon, nouveau, and dw-hdmi drivers all gate audio enablement on
>display_info.has_audio. Apply the same check to amdgpu's DCE
>afmt_setmode functions.
>
>Signed-off-by: renpanpan <[email protected]>
>---
> drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 5 +++--
> drivers/gpu/drm/amd/amdgpu/dce_v6_0.c  | 5 +++--
> drivers/gpu/drm/amd/amdgpu/dce_v8_0.c  | 5 +++--
> 3 files changed, 9 insertions(+), 6 deletions(-)
>
>diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c 
>b/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c
>index f2977fe6d824..04b18056a906 100644
>--- a/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c
>+++ b/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c
>@@ -1705,8 +1705,9 @@ static void dce_v10_0_afmt_setmode(struct drm_encoder 
>*encoder,
>       WREG32(mmAFMT_RAMP_CONTROL2 + dig->afmt->offset, 0x00000001);
>       WREG32(mmAFMT_RAMP_CONTROL3 + dig->afmt->offset, 0x00000001);
> 
>-      /* enable audio after to setting up hw */
>-      dce_v10_0_audio_enable(adev, dig->afmt->pin, true);
>+      /* Only enable audio if the display supports it */
>+      if (connector->display_info.has_audio)
>+              dce_v10_0_audio_enable(adev, dig->afmt->pin, true);
> }
> 
> static void dce_v10_0_afmt_enable(struct drm_encoder *encoder, bool enable)
>diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c 
>b/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c
>index c68de0fe1d7d..585b0a50279f 100644
>--- a/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c
>+++ b/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c
>@@ -1748,8 +1748,9 @@ static void dce_v6_0_afmt_setmode(struct drm_encoder 
>*encoder,
>               dce_v6_0_audio_dp_enable(encoder, 1);
>       }
> 
>-      /* enable audio after setting up hw */
>-      dce_v6_0_audio_enable(adev, dig->afmt->pin, true);
>+      /* Only enable audio if the display supports it */
>+      if (connector->display_info.has_audio)
>+              dce_v6_0_audio_enable(adev, dig->afmt->pin, true);
> }
> 
> static void dce_v6_0_afmt_enable(struct drm_encoder *encoder, bool enable)
>diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c 
>b/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c
>index c3906270f25e..1390efa4ea51 100644
>--- a/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c
>+++ b/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c
>@@ -1653,8 +1653,9 @@ static void dce_v8_0_afmt_setmode(struct drm_encoder 
>*encoder,
>       WREG32(mmAFMT_RAMP_CONTROL2 + offset, 0x00000001);
>       WREG32(mmAFMT_RAMP_CONTROL3 + offset, 0x00000001);
> 
>-      /* enable audio after setting up hw */
>-      dce_v8_0_audio_enable(adev, dig->afmt->pin, true);
>+      /* Only enable audio if the display supports it */
>+      if (connector->display_info.has_audio)
>+              dce_v8_0_audio_enable(adev, dig->afmt->pin, true);
> }
> 
> static void dce_v8_0_afmt_enable(struct drm_encoder *encoder, bool enable)
>-- 
>2.43.0

Reply via email to