Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] drm/bridge: wrong kernel-doc tag for hdmi_write_vtem_emp in drm_bridge_funcs --
commit db5205bd90d10ddf734b146e8cd3c0d61b65f621 Author: Derek Foreman <[email protected]> drm/bridge: Add VTEM EMP support This commit adds VTEM EMP callbacks, the DRM_BRIDGE_OP_HDMI_VTEM_EMP operation flag, and corresponding drm_bridge_connector wiring to support VTEM extended metadata packets on HDMI bridges. > diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h > index 1981d24a700d2..6913662023cae 100644 > --- a/include/drm/drm_bridge.h > +++ b/include/drm_bridge.h > @@ -684,6 +684,29 @@ struct drm_bridge_funcs { > int (*hdmi_write_spd_infoframe)(struct drm_bridge *bridge, > const u8 *buffer, size_t len); > > + /** > + * @hdmi_clear_vtem_emp: > + * > + * This callback clears the emp in the hardware during commit. > + * > + * This callback is optional but it must be implemented by bridges that > + * set the DRM_BRIDGE_OP_HDMI_VTEM_EMP flag in their > + * &drm_bridge->ops. > + */ > + int (*hdmi_clear_vtem_emp)(struct drm_bridge *bridge); > + > + /** > + * @hdmi_write_spd_infoframe: > + * > + * Program the emp into the hardware. > + * > + * This callback is optional but it must be implemented by bridges that > + * set the DRM_BRIDGE_OP_HDMI_VTEM_EMP flag in their > + * &drm_bridge->ops. > + */ > + int (*hdmi_write_vtem_emp)(struct drm_bridge *bridge, > + const u8 *buffer, size_t len); [Severity: Low] As reported by Sashiko on RFC [1], should the kernel-doc comment for hdmi_write_vtem_emp in struct drm_bridge_funcs in include/drm/drm_bridge.h use @hdmi_write_vtem_emp: instead of @hdmi_write_spd_infoframe:, so that running scripts/kernel-doc does not warn about a duplicate @hdmi_write_spd_infoframe section and an undescribed hdmi_write_vtem_emp member? [1] https://lore.kernel.org/r/[email protected] -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=4
