Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] drm/tests: double ctx cleanup in drm_test_check_hdmi_vrr_target_rate_fail() --
commit 75a8664a7bf8d42311eb56958c313fafe87f6d41 Author: Nicolas Frattaroli <[email protected]> drm/tests: hdmi: Add Fixed/Constrained rate VRR tests This commit adds KUnit tests for HDMI VRR fixed and constrained target rates, including CinemaVRR and invalid target rate checks. > diff --git a/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c > b/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c > index 09ce304210892..7da26b3713d8c 100644 > --- a/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c > +++ b/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c > @@ -3673,10 +3673,396 @@ static void > drm_test_check_hdmi_vrr_flush_vsync(struct kunit *test) [ ... ] > +static void drm_test_check_hdmi_vrr_target_rate_fail(struct kunit *test) > +{ > + const struct vrr_target_error_params *params = test->param_value; > + struct drm_atomic_helper_connector_hdmi_priv *priv; > + struct drm_modeset_acquire_ctx ctx; > + struct drm_display_mode *preferred; > + struct drm_crtc_state *crtc_state; > + struct drm_atomic_commit *state; > + struct drm_connector *conn; > + int ret; > + > + priv = drm_kunit_helper_connector_hdmi_init_with_edid_funcs(test, > + BIT(DRM_OUTPUT_COLOR_FORMAT_RGB444), > + 8, > + &dummy_connector_hdmi_funcs, > + test_edid_hdmi_vrr); > + KUNIT_ASSERT_NOT_NULL(test, priv); > + > + conn = &priv->connector; > + KUNIT_ASSERT_TRUE(test, conn->display_info.is_hdmi); > + KUNIT_ASSERT_TRUE(test, conn->display_info.hdmi.vrr_cap.supported); > + KUNIT_ASSERT_LT(test, 24, conn->display_info.hdmi.vrr_cap.vrr_min); > + > + preferred = find_preferred_mode(conn); > + KUNIT_ASSERT_NOT_NULL(test, preferred); > + > + guard(modeset_lock)(&ctx); > + > + allocate_state_for_vrr_test(test, priv, &ctx, preferred, &state); > + > +retry: > + prepare_state_for_vrr_test(test, priv, &ctx, state, &crtc_state); > + > + /* > + * Allow individual test parameters to play with the CinemaVRR flag > + * without needing to bring their own modified EDID. > + */ > + conn->display_info.hdmi.vrr_cap.cinema_vrr = > params->cinema_vrr_override; > + > + crtc_state->vrr_enabled = true; > + crtc_state->vrr_state.vrr_min_n = params->vrr_min_n; > + crtc_state->vrr_state.vrr_min_d = params->vrr_min_d; > + crtc_state->vrr_state.vrr_max_n = params->vrr_max_n; > + crtc_state->vrr_state.vrr_max_d = params->vrr_max_d; > + > + ret = drm_atomic_commit(state); > + if (ret == -EDEADLK) { > + drm_atomic_commit_clear(state); > + ret = drm_modeset_backoff(&ctx); > + if (!ret) > + goto retry; > + } > + KUNIT_EXPECT_LT(test, ret, 0); > + > + drm_modeset_drop_locks(&ctx); > + drm_modeset_acquire_fini(&ctx); > +} [Severity: Medium] Since guard(modeset_lock)(&ctx) is used earlier in drm_test_check_hdmi_vrr_target_rate_fail(), drop_fini_modeset(&ctx) will automatically run when the function exits: static void drop_fini_modeset(struct drm_modeset_acquire_ctx *ctx) { drm_modeset_drop_locks(ctx); drm_modeset_acquire_fini(ctx); } DEFINE_GUARD(modeset_lock, struct drm_modeset_acquire_ctx *, drm_modeset_acquire_init(_T, 0), drop_fini_modeset(_T)); Won't calling drm_modeset_drop_locks(&ctx) and drm_modeset_acquire_fini(&ctx) explicitly at the end of the function cause ctx to be finalized twice via ww_acquire_fini(), triggering lockdep or DEBUG_WW_MUTEXES warnings? -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=23
