Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] drm/tests: commit message does not match added tests in drm_atomic_test.c --
commit 7731bb22d966b9a3d8a35a7cc0ac3d23e9fd7680 Author: Maxime Ripard <[email protected]> > drm/tests: atomic: Add tests for drm_atomic_commit_fill_with_defaults() > > drm_atomic_commit_fill_with_defaults() is used by the > DRM_MODE_ATOMIC_RESET flag to bring all objects back to their pristine > state. However, it has no dedicated test coverage. > > Add two tests that verify the reset cycle. The first enables a CRTC, > plane, and connector, then calls drm_atomic_commit_fill_with_defaults() > and verifies all objects return to their disabled state: CRTC inactive, > plane disabled with no framebuffer, and connector unbound. The second > goes further and commits the default-filled state to verify the > init -> enable -> reset -> commit sequence completes without errors. > > Suggested-by: Daniel Stone <[email protected]> > Signed-off-by: Maxime Ripard <[email protected]> [Severity: Low] Does the commit message match the tests added in drm_atomic_fill_with_defaults_tests? The commit message describes two tests, whereas the patch adds four: drm_test_check_fill_with_defaults(), drm_test_check_fill_with_defaults_commit(), drm_test_check_fill_with_defaults_color_mgmt(), and drm_test_check_fill_with_defaults_no_modeset(). Also, as noted in the test comments, drm_test_check_fill_with_defaults() only enables the CRTC and connector via drm_kunit_helper_enable_crtc_connector() and does not enable the plane with a framebuffer. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=5
