Thank you for your contribution! Sashiko AI review found 1 potential issue(s) 
to consider:
- [Medium] drm/rockchip: rgb: unguarded drm_panel_bridge_remove() in 
rockchip_rgb_init()
--

commit 236134a70cc9d3d8c07b195274e3306b33801a49
Author: Wentao Liang <[email protected]>

drm/rockchip: rgb: fix panel bridge reference leak on setup error

This commit adds a call to drm_panel_bridge_remove() in the error path of
rockchip_rgb_init() to release the panel bridge reference when
drm_bridge_attach() or drm_bridge_connector_init() fails.

> diff --git a/drivers/gpu/drm/rockchip/rockchip_rgb.c 
> b/drivers/gpu/drm/rockchip/rockchip_rgb.c
> index 0e1830bc40eec..10219638c0a24 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_rgb.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_rgb.c
> @@ -172,6 +172,7 @@ struct rockchip_rgb *rockchip_rgb_init(struct device *dev,
>       return rgb;
>  
>  err_free_encoder:
> +     drm_panel_bridge_remove(rgb->bridge);
>       drm_encoder_cleanup(encoder);

[Severity: Medium]
Can calling drm_panel_bridge_remove(rgb->bridge) unconditionally here trigger
a warning on non-panel bridges and reverse the teardown order?

In rockchip_rgb_init(), drm_of_find_panel_or_bridge() can find either a
drm_panel or a standalone non-panel drm_bridge, and
drm_panel_bridge_add_typed() is only called when panel is non-NULL:

drivers/gpu/drm/rockchip/rockchip_rgb.c:rockchip_rgb_init() {
        ...
                ret = drm_of_find_panel_or_bridge(dev->of_node, video_port,
                                                  endpoint_id, &panel, &bridge);
        ...
        if (panel) {
                bridge = drm_panel_bridge_add_typed(panel,
                                                    DRM_MODE_CONNECTOR_LVDS);
                drm_panel_put(panel);
                if (IS_ERR(bridge))
                        return ERR_CAST(bridge);
        }

        rgb->bridge = bridge;
}

When panel is NULL and rgb->bridge is an external non-panel bridge, if
drm_bridge_attach() or drm_bridge_connector_init() fails, jumping to
err_free_encoder calls drm_panel_bridge_remove(rgb->bridge), which hits the
non-panel warning in drm_panel_bridge_remove():

drivers/gpu/drm/drm_panel.c:drm_panel_bridge_remove() {
        if (!bridge)
                return;

        if (!drm_bridge_is_panel(bridge)) {
                drm_warn(bridge->dev, "%s: called on non-panel bridge!\n", 
__func__);
                return;
        }

        drm_bridge_put(bridge);
}

Also, when drm_bridge_attach() succeeds and drm_bridge_connector_init()
subsequently fails, rgb->bridge is already attached to encoder->bridge_chain.
Should drm_panel_bridge_remove(rgb->bridge) be guarded by if (panel) and
called after drm_encoder_cleanup(encoder) detaches the bridge?

-- 
Sashiko AI review ยท 
https://sashiko.dev/#/patchset/[email protected]?part=1

Reply via email to