Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] drm/vkms: missing Fixes trailer for LUT size fix in vkms_atomic_check() --
commit ce5b5586969b38a36fc2d39e5403ee7e86059811 Author: Leandro Ribeiro <[email protected]> > vkms: properly compute gamma LUT size in vkms_atomic_check() > > Gamma LUT size is being computed wrongly, dividing blob size by > sizeof(struct drm_color_lut *). But the blob is an array of struct > drm_color_lut. > > Replace sizeof(struct drm_color_lut *) with sizeof(struct > drm_color_lut), properly validating the userspace gamma LUT size. > > Issue caught by Sashiko bot: > https://sashiko.dev/#/patchset/[email protected]?part=1 > > Reported-by: Sashiko <[email protected]> > Reviewed-by: Robert Mader <[email protected]> > Tested-by: Robert Mader <[email protected]> > Signed-off-by: Leandro Ribeiro <[email protected]> [Severity: Low] Since this fixes the gamma LUT size check in vkms_atomic_check(), which rejected valid 129-to-256-entry LUTs on 32-bit architectures where sizeof(struct drm_color_lut *) is 4 bytes instead of 8, should the commit message include: Fixes: db1f254f2cfa ("drm/vkms: Add support to 1D gamma LUT") -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=2
