Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] drm/panel: hiby-lg35583: reverse regulator disable order in lg35583_unprepare() --
commit d7b0c5c3d496f641bc7958504a4bf1c7175af30f Author: Olivier Louvignes <[email protected]> drm/panel: Add the HiBy LG35583 This commit adds a DRM panel driver for the HiBy LG35583 480x800 parallel RGB panel configured over a 3-wire SPI bus. > diff --git a/drivers/gpu/drm/panel/panel-hiby-lg35583.c > b/drivers/gpu/drm/panel/panel-hiby-lg35583.c > new file mode 100644 > index 0000000000000..47aba09e91a4c > --- /dev/null > +++ b/drivers/gpu/drm/panel/panel-hiby-lg35583.c [ ... ] > +static int lg35583_prepare(struct drm_panel *panel) > +{ > + struct lg35583 *ctx = to_lg35583(panel); > + unsigned int i; > + int ret; > + > + ret = regulator_enable(ctx->vccio); > + if (ret) > + return ret; > + usleep_range(5000, 6000); > + > + ret = regulator_enable(ctx->vcc); > + if (ret) > + goto err_vccio; [ ... ] > +err_vcc: > + gpiod_set_value_cansleep(ctx->reset, 1); > + regulator_disable(ctx->vcc); > +err_vccio: > + regulator_disable(ctx->vccio); > + return ret; > +} [ ... ] > +static int lg35583_unprepare(struct drm_panel *panel) > +{ > + struct lg35583 *ctx = to_lg35583(panel); > + > + lg35583_cmd(ctx, LG35583_SLPIN); > + usleep_range(5000, 6000); > + > + gpiod_set_value_cansleep(ctx->reset, 1); > + regulator_disable(ctx->vccio); > + regulator_disable(ctx->vcc); > + return 0; > +} [Severity: Low] Should lg35583_unprepare() disable ctx->vcc before ctx->vccio? lg35583_prepare() enables ctx->vccio before ctx->vcc and disables ctx->vcc first in its error path, whereas lg35583_unprepare() turns off the I/O supply while the main panel supply is still enabled. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=5
