Nouveau uses wmi_evaluate_method() when CONFIG_ACPI_WMI has been
enabled, but this alone does not guarantee that CONFIG_ACPI_WMI
is actually reachable. If CONFIG_ACPI_WMI is m and CONFIG_DRM_NOUVEAU
is y, said function will not be reachable by nouveau, resulting in
a linker error.

Until now this issue was not triggered because on x86
CONFIG_ACPI_WMI is automatically selected by nouveau. However the
ACPI-WMI subsystem has added support for other ACPI-compatible
architectures like Risc V, making it possible for users to trigger
this bug.

Fix this by always selecting ACPI_WMI if ACPI support is enabled
to ensure that nouveau can actually reach wmi_evaluate_method().

Fixes: 884d53763d30 ("platform/wmi: Remove dependency on CONFIG_X86")
Reported-by: kernel test robot <[email protected]>
Closes: 
https://lore.kernel.org/oe-kbuild-all/[email protected]/
Signed-off-by: Armin Wolf <[email protected]>
---
 drivers/gpu/drm/nouveau/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/Kconfig b/drivers/gpu/drm/nouveau/Kconfig
index 3b5757aed9c8..9c5716738b18 100644
--- a/drivers/gpu/drm/nouveau/Kconfig
+++ b/drivers/gpu/drm/nouveau/Kconfig
@@ -19,7 +19,7 @@ config DRM_NOUVEAU
        select I2C_ALGOBIT
        select BACKLIGHT_CLASS_DEVICE if DRM_NOUVEAU_BACKLIGHT
        select X86_PLATFORM_DEVICES if ACPI && X86
-       select ACPI_WMI if ACPI && X86
+       select ACPI_WMI if ACPI
        select MXM_WMI if ACPI && X86
        select POWER_SUPPLY
        # Similar to i915, we need to select ACPI_VIDEO and it's dependencies
-- 
2.56.0

Reply via email to