Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [High] drm/panel: build failure in vc4 driver after removing drmm_of_get_bridge() --
commit 4e516e61e060977ea843a480424ba4b15e3d19c9 Author: Luca Ceresoli <[email protected]> drm/panel: remove drmm_of_get_bridge() This commit removes the deprecated drmm_of_get_bridge() helper and its header declarations. > diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/drm/drm_panel.c > index c00529bfb706b..12f39ce1b7035 100644 > --- a/drivers/gpu/drm/drm_panel.c > +++ b/drivers/gpu/drm/drm_panel.c [ ... ] > -struct drm_bridge *drmm_of_get_bridge(struct drm_device *drm, > - struct device_node *np, > - u32 port, u32 endpoint) > -{ > - struct drm_bridge *bridge; > - struct drm_panel *panel; > - int ret; > - > - ret = drm_of_find_panel_or_bridge(np, port, endpoint, > - &panel, &bridge); > - if (ret) > - return ERR_PTR(ret); > - > - if (panel) { > - bridge = drmm_panel_bridge_add(drm, panel); > - drm_panel_put(panel); > - } > - > - return bridge; > -} > -EXPORT_SYMBOL(drmm_of_get_bridge); [Severity: High] Does removing drmm_of_get_bridge() break building the vc4 driver? vc4_dpi_init_bridge() in drivers/gpu/drm/vc4/vc4_dpi.c and vc4_dsi_bind() in drivers/gpu/drm/vc4/vc4_dsi.c still call drmm_of_get_bridge(drm, dev->of_node, 0, 0). -- Sashiko AI review ยท https://sashiko.dev/#/patchset/20261106-drm-panel_bridge-remove-drmm_of_get_bridge-v1-0-c0ea3382b...@bootlin.com?part=2
