Changes to how the A508, A509 and A512 power up and down, found running a phone shell on an SDM630 phone.
The second resets the GPU on every resume: on SDM630, SDM660 and MSM8998 the device tree attaches the GPU's GX power domain to its SMMU, so a GPU resumed soon after suspending keeps its state, and its CP runs stale ringbuffer contents and hangs. The reset clears the busy counter devfreq samples, so the first lets each GPU resume devfreq from its own resume callback, and the second resumes it after the reset. The third holds a CPU latency request while the GPU is powered, as the downstream driver does: on SDM630 the GPU stops executing while the SoC is in system-level power collapse, so a submission overlapping such a state would stall and trip the hang detector. Mainline does not describe that state yet, so the request blocks nothing until it does. The fourth powers these GPUs down after downstream's 80 ms idle instead of the A530's 250 ms, so the request is released when downstream releases it. Each patch builds on the one before it. Tested on a Motorola Moto X4 (SDM630, A508), whose board file is not in mainline yet, on sdm660-mainline's 7.2 kernel. The stall the third patch prevents was measured with SDM630's system-level idle state from a series not yet sent. --- Changes in v3: - New patch 1: resume devfreq from each GPU's resume callback (Akhil) - Patch 2: say that the device tree attaches GX to the SMMU, whose own domain is CX (Konrad, Akhil); resume devfreq after the reset instead of taking its baseline again (Akhil); dropped Dmitry's Tested-by - Patch 3: take 2336 us, which leaves every CPU and cluster idle state available, instead of downstream's 424 and 518 us, which also kept every CPU out of power collapse (Dmitry); drop the request on destroy after adreno_gpu_cleanup(), which stops runtime PM and the GPU worker, so nothing can take it again before it is freed (Sashiko) - Link to v2: https://patch.msgid.link/[email protected] Changes in v2: - Patch 1: take devfreq's busy-cycle baseline again after the reset, which clears the busy counter (Sashiko) - Link to v1: https://patch.msgid.link/[email protected] --- Fabricio Akio (4): drm/msm: Resume devfreq from each GPU's resume callback drm/msm/a5xx: Reset the GPU when resuming it drm/msm/a5xx: Hold a CPU latency request while the GPU is powered drm/msm/a5xx: Use the downstream GPU idle timeout on A508, A509 and A512 drivers/gpu/drm/msm/adreno/a3xx_gpu.c | 15 ++++++++++++++- drivers/gpu/drm/msm/adreno/a4xx_gpu.c | 2 ++ drivers/gpu/drm/msm/adreno/a5xx_catalog.c | 21 ++++++--------------- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 29 +++++++++++++++++++++++++++++ drivers/gpu/drm/msm/adreno/a5xx_gpu.h | 4 ++++ drivers/gpu/drm/msm/adreno/adreno_gpu.h | 5 +++++ drivers/gpu/drm/msm/msm_gpu.c | 2 -- 7 files changed, 60 insertions(+), 18 deletions(-) --- base-commit: a39c950806213f6861d00f90729acaaa21f2d95a change-id: 20261019-a5xx-gpu-pm-f58bc4ee2387 Best regards, -- Fabricio Akio <[email protected]>
