On Tue, Nov 03, 2026 at 01:43:13PM +0000, [email protected] wrote: > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) > to consider: > - [Medium] ARM: sunxi: HAVE_SHARED_GPIOS ignores 3-cell sunxi SoC GPIO > bindings > -- > > commit 08b8c5df755142dacaed1d91af688663b9db7e82 > Author: Bartosz Golaszewski <[email protected]> > > ARM: sunxi: select HAVE_SHARED_GPIOS > > This commit selects HAVE_SHARED_GPIOS for ARCH_SUNXI to enable automated > management of shared GPIOs via the GPIO shared proxy module on sunxi > platforms. > > > diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig > > index e015f2497111a..b62e8518e2704 100644 > > --- a/arch/arm/mach-sunxi/Kconfig > > +++ b/arch/arm/mach-sunxi/Kconfig > > @@ -5,6 +5,7 @@ menuconfig ARCH_SUNXI > > select ARCH_HAS_RESET_CONTROLLER > > select CLKSRC_MMIO > > select GPIOLIB > > + select HAVE_SHARED_GPIOS > > [Severity: Medium] > Does selecting HAVE_SHARED_GPIOS here actually work for Allwinner sunxi SoC > GPIO controllers? > > Allwinner sunxi pinctrl/GPIO controllers (&pio and &r_pio) use 3-cell GPIO > specifiers (#gpio-cells = <3>: bank, pin, flags), as translated in > drivers/pinctrl/sunxi/pinctrl-sunxi.c:sunxi_pinctrl_gpio_of_xlate(): >
Right, shared GPIOs need support for 3-cell bindings first. Let's drop this for now. Bart
