Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] drm/atomic_sro: missing linux/types.h include in drm_atomic_state_readout.h --
commit dc962b96e1dce7bf194a4cf4ec09437eb2d463c9 Author: Maxime Ripard <[email protected]> drm/atomic_sro: Create kernel parameter to force or disable readout This commit adds the drm.atomic_readout module parameter and drm_atomic_sro_device_can_readout() to control KMS atomic hardware state readout. > diff --git a/include/drm/drm_atomic_state_readout.h > b/include/drm/drm_atomic_state_readout.h > index 5a9333a057964..955e2de9d5b1d 100644 > --- a/include/drm/drm_atomic_state_readout.h > +++ b/include/drm/drm_atomic_state_readout.h > @@ -15,6 +15,15 @@ struct drm_printer; > struct drm_private_obj; > struct drm_private_state; > > +enum drm_atomic_readout_status { > + DRM_ATOMIC_READOUT_DISABLED = 0, > + DRM_ATOMIC_READOUT_ENABLED, > + DRM_ATOMIC_READOUT_SKIP_MISSING_COMPARE, > + DRM_ATOMIC_READOUT_SKIP_MISSING_READOUT, > +}; > + > +bool drm_atomic_sro_device_can_readout(struct drm_device *dev); [Severity: Low] Does include/drm/drm_atomic_state_readout.h need to include <linux/types.h> for bool? Without it, building with CONFIG_DRM_HEADER_TEST=y fails when compiling drm_atomic_state_readout.hdrtest standalone. A later patch in the series, commit "drm/atomic_helper: Compare actual and readout states once the commit is done", adds #include <linux/types.h>, so moving that include into this patch would keep bisection working across the series. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=14
