Thank you for your contribution! Sashiko AI review found 2 potential issues to consider: - [Medium] drm/panthor: dropped YIELD_IDLE command in arb_sched_next_locked() - [Medium] drm/panthor: dropped GPU_REQUEST in panthor_arbitration_sched_on_request() --
commit f99f87c6e1d4cdf3c37b5e1e28569f0fc943d72a Author: Karunika Choo <[email protected]> drm/panthor: Request AW to yield GPU access on idle This commit sends a YIELD_IDLE notification to the active access window when other access windows are waiting in the arbitration scheduler queue or when a second access window requests GPU access. > diff --git a/drivers/gpu/drm/panthor/arbitration/panthor_arbitration_sched.c > b/drivers/gpu/drm/panthor/arbitration/panthor_arbitration_sched.c > index 16bd0fac2514e..f137b73deaa32 100644 > --- a/drivers/gpu/drm/panthor/arbitration/panthor_arbitration_sched.c > +++ b/drivers/gpu/drm/panthor/arbitration/panthor_arbitration_sched.c [ ... ] > @@ -382,6 +394,10 @@ static int arb_sched_next_locked(struct > panthor_arbitration_sched *sched) > > arb_sched_grant_locked(sched); > > + if (sched->phase == ARB_SCHED_PHASE_GRANTED && > + !kfifo_is_empty(&sched->queue)) > + arb_sched_yield_idle_locked(sched); > + > wake_up_all(&sched->waitqueue); > > return 0; [Severity: Medium] Can arb_sched_yield_idle_locked() silently drop the YIELD_IDLE command when called immediately after arb_sched_grant_locked()? arb_sched_grant_locked() calls window_open(), which writes PART_CMD_OPEN_WINDOW to AM_PART_COMMAND and returns 0 without waiting for AM_PART_STATE to leave PART_STATE_RESET. When arb_sched_yield_idle_locked() then calls yield_idle(), AM_PART_STATE can still read as PART_STATE_RESET: drivers/gpu/drm/panthor/arbitration/panthor_partition_control.c:yield_idle() { guard(spinlock_irqsave)(&pc->lock); if (partition_state_get(pc) == PART_STATE_RESET) return 0; if (partition_state_get(pc) != PART_STATE_WINDOW_OPEN) return -EAGAIN; ... } Because yield_idle() returns 0 instead of -EAGAIN in PART_STATE_RESET, arb_sched_yield_idle_locked() does not queue PANTHOR_ARB_WORK_YIELD_IDLE, and the active access window holds the GPU even while idle until grant_timer expires. [ ... ] > @@ -551,8 +573,18 @@ int panthor_arbitration_sched_on_request(struct > panthor_arbitration_sched *sched > * Grant timer for the current AW has previously expired, request it to > * yield the GPU. > */ > - if (sched->grant_previously_expired) > + if (sched->grant_previously_expired) { > arb_sched_request_stop_locked(sched); > + return 0; > + } > + > + /* > + * GPU was previously granted to a lone requesting AW, YIELD_IDLE was > + * not sent to it. Send YIELD_IDLE to it now that multiple AWs are > + * requesting for the GPU. > + */ > + if (sched->phase == ARB_SCHED_PHASE_GRANTED && kfifo_len(&sched->queue) > == 1) > + arb_sched_yield_idle_locked(sched); > > return 0; > } [Severity: Medium] Will panthor_arbitration_sched_on_request() drop a new GPU_REQUEST from an access window that just yielded due to YIELD_IDLE? Unlike arb_sched_request_stop_locked(), which sets sched->phase to ARB_SCHED_PHASE_STOPPING before sending PART_CMD_YIELD_NOW, sending PART_CMD_YIELD_IDLE leaves sched->phase as ARB_SCHED_PHASE_GRANTED. When the active access window yields on idle, it receives WINDOW_IRQ_WINDOW_CLOSED and can issue a new VM_ARB_GPU_REQUEST before the partition control IRQ processes PART_RESET_DONE and calls panthor_arbitration_on_stopped(): drivers/gpu/drm/panthor/arbitration/panthor_arbitration_sched.c:panthor_arbitration_sched_on_request() { ... if (test_bit(aw_id, sched->queued_mask) || (sched->active_aw_id == aw_id && sched->phase != ARB_SCHED_PHASE_STOPPING)) { dev_warn(sched->dev, "%s: AW%u already in request queue.", sched->name, aw_id); return -EEXIST; } ... } Because sched->active_aw_id is still aw_id and sched->phase is still ARB_SCHED_PHASE_GRANTED, panthor_arbitration_sched_on_request() rejects the request with -EEXIST, leaving the access window to time out in panthor_aw_request(). -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=21
