Hi Prabhakar,

> -----Original Message-----
> From: Prabhakar <[email protected]>
> Sent: 11 November 2026 11:33
> Subject: [PATCH v4] drm: renesas: rzg2l_mipi_dsi: Remove redundant driver 
> data assignment
> 
> From: John Madieu <[email protected]>
> 
> rzg2l_mipi_dsi_probe() calls platform_set_drvdata() twice with the same
> arguments: once immediately after devm_drm_bridge_alloc() succeeds and again 
> after the DCS buffer has
> been allocated.
> 
> Drop the first call and keep the second one, as it is closer to where the 
> platform data is actually
> used.
> 
> Signed-off-by: John Madieu <[email protected]>
> Signed-off-by: Lad Prabhakar <[email protected]>

Reviewed-by: Biju Das <[email protected]>

Cheers,
Biju

> ---
> v3->v4:
>  - Updated commit message
>  - Dropped the first driver data assignment in rzg2l_mipi_dsi_probe()
>  v3: 
> https://lore.kernel.org/all/[email protected]/
>  v2: 
> https://lore.kernel.org/all/[email protected]/
>  v1: 
> https://lore.kernel.org/all/[email protected]/
>  ---
>  drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c 
> b/drivers/gpu/drm/renesas/rz-
> du/rzg2l_mipi_dsi.c
> index 5b257f5adf06..65f26f889a67 100644
> --- a/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c
> +++ b/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c
> @@ -1532,7 +1532,6 @@ static int rzg2l_mipi_dsi_probe(struct platform_device 
> *pdev)
>       if (IS_ERR(dsi))
>               return PTR_ERR(dsi);
> 
> -     platform_set_drvdata(pdev, dsi);
>       dsi->dev = &pdev->dev;
> 
>       dsi->info = of_device_get_match_data(&pdev->dev);
> --
> 2.56.1

Reply via email to