On Mon, Nov 9, 2026 at 5:50 PM <[email protected]> wrote:
> [Severity: Low]
> Should this commit include a Fixes: tag for the commit that introduced the
> leak:
>
>   Fixes: 1ea28bc5542d ("drm: handle kernel fences in 
> drm_gem_plane_helper_prepare_fb v2")

Thanks, v2 will include the fix tag.

On Mon, Nov 9, 2026 at 5:50 PM <[email protected]> wrote:
>
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue to consider:
> - [Low] drm/gem-atomic-helper: missing Fixes trailer for commit
>   1ea28bc5542d
> --
>
> commit b6d9ff23bfcc702d784107d5026972257646c1fc
> Author: Chengyu Liu <[email protected]>
>
> > drm/gem-atomic-helper: fix fence leak on dma_fence_chain_alloc() failure
> >
> > In drm_gem_plane_helper_prepare_fb(), when both "new" (the plane's GEM
> > singleton fence) and "fence" (explicit or previous plane's) exist, they
> > are wrapped in a freshly allocated chain.  If dma_fence_chain_alloc()
> > fails, the error path runs before dma_fence_chain_init() adopts "new",
> > and error: only puts "fence" - leaking one fence reference per failure.
> >
> > Put "new" in the allocation-failure branch.
> >
> > Found by static analysis.
> >
> > Signed-off-by: Chengyu Liu <[email protected]>
>
> [Severity: Low]
> Should this commit include a Fixes: tag for the commit that introduced the
> leak:
>
>   Fixes: 1ea28bc5542d ("drm: handle kernel fences in 
> drm_gem_plane_helper_prepare_fb v2")
>
> --
> Sashiko AI review · 
> https://sashiko.dev/#/patchset/[email protected]?part=1

Reply via email to