Thank you for your contribution! Sashiko AI review found no new issues in this patch, but noticed 1 related pre-existing issue it does not introduce: - [High] drm/panel: ilitek-ili9881c: missing lanes init in three panel descriptors [1] --
commit 40a8a814e1b52ccce761f231179cd2bd05641a2c Author: Philipp Zabel <[email protected]> drm/panel: ilitek-ili9881c: Fix Ampire AM8001280G support This commit sets .lanes = 4 in am8001280g_desc to restore the lane count for Ampire AM8001280G panels. > diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c > b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c > index 7bf38e96678ac..cc4cd646b6111 100644 > --- a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c > +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c > @@ -2662,6 +2662,7 @@ static const struct ili9881c_desc am8001280g_desc = { > .mode = &am8001280g_default_mode, > .mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE | > MIPI_DSI_CLOCK_NON_CONTINUOUS | MIPI_DSI_MODE_LPM, > + .lanes = 4, > }; [Severity: High] This problem wasn't introduced by this patch, but are kd050hdfia020_desc and tl050hdv35_desc also missing their .lanes initializer from 2f7e4a699736 ("drm/panel: ilitek-ili9881c: Allow configuration of the number of lanes") [1]? Without .lanes set, ili9881c_dsi_probe() passes dsi->lanes == 0 to mipi_dsi_attach(), causing DSI host attachment to fail with -EINVAL or triggering a division by zero in DSI host controller drivers that divide by dsi->lanes. [1] https://sashiko.dev/#/bug/linux-62dd6149-f822-4521-aeee-730978e33590 -- Sashiko AI review ยท https://sashiko.dev/#/patchset/20261113-panel-ilitek9881c-lanes-v1-0-9d9320cc1...@pengutronix.de?part=1
