Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] dt-bindings: npu: rockchip: unwieldy per-compatible allOf in rknn-core --
commit a0f34734ea2ccc04a47837d4a01f9cdb7cf55a23 Author: Jiaxing Hu <[email protected]> dt-bindings: npu: rockchip: add rockchip,rk3576-rknn-core This commit adds the rockchip,rk3576-rknn-core compatible string to the Rockchip RKNN core binding and defines per-SoC clock, reset, and regulator constraints in an allOf conditional block. > diff --git > a/Documentation/devicetree/bindings/npu/rockchip,rk3588-rknn-core.yaml > b/Documentation/devicetree/bindings/npu/rockchip,rk3588-rknn-core.yaml > index caca2a4903cd1..2eb9337819e67 100644 > --- a/Documentation/devicetree/bindings/npu/rockchip,rk3588-rknn-core.yaml > +++ b/Documentation/devicetree/bindings/npu/rockchip,rk3588-rknn-core.yaml > @@ -21,6 +21,7 @@ properties: > > compatible: > enum: > + - rockchip,rk3576-rknn-core > - rockchip,rk3588-rknn-core > > reg: > @@ -33,14 +34,18 @@ properties: > - const: core # Main NPU core processing unit registers > > clocks: > - maxItems: 4 > + minItems: 4 > + maxItems: 6 > > clock-names: > + minItems: 4 > items: > - const: aclk > - const: hclk > - const: npu > - const: pclk > + - const: aclk_cbuf > + - const: hclk_cbuf > > interrupts: > maxItems: 1 > @@ -54,9 +59,11 @@ properties: > maxItems: 1 > > resets: > + minItems: 1 > maxItems: 2 > > reset-names: > + minItems: 1 > items: > - const: srst_a > - const: srst_h > @@ -75,7 +82,36 @@ required: > - resets > - reset-names > - npu-supply > - - sram-supply > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + const: rockchip,rk3588-rknn-core > + then: > + properties: > + clocks: > + maxItems: 4 > + clock-names: > + maxItems: 4 > + resets: > + minItems: 2 > + reset-names: > + minItems: 2 > + required: > + - sram-supply > + else: > + properties: > + clocks: > + minItems: 6 > + clock-names: > + minItems: 6 > + resets: > + maxItems: 1 > + reset-names: > + maxItems: 1 > + sram-supply: false > > additionalProperties: false [Severity: Low] This isn't a bug, but since rockchip,rk3576-rknn-core and rockchip,rk3588-rknn-core differ across clocks, clock-names, resets, reset-names, and sram-supply, would it be cleaner to split rockchip,rk3576-rknn-core into its own schema document rather than loosening the top-level properties and overriding all of them in allOf? -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=6
